#53 Red Border

Closed
opened 1 year ago by jidrivefya · 14 comments

name: Bug report(?)
about: Red rectangular border (Strict Mode check?)
*Device info (please complete the following information): -
Device: Samsung Galaxy Note 5 -
OS: Andrid Nougat 7.0 -
Arch: arm64 -
Variant: monochrome -
Version: 84.0.4147.89

*Is the bug related to extensions/on the extension-support version?
No

*If not related to extensions/extension-support version, can the bug be reproduced with corresponding non-extension-support ungoogled-chromium-android version?
Yes

*If not related to extensions/extension-support version, can the bug be reproduced with corresponding vanilla Chromium (the one directly from Google) version?
I don't know.

*Describe the bug
Tapping on the menu button, launching the app and a few other things trigger it. A red border appears and flashes for less than a second.

*To Reproduce
Steps to reproduce the behavior:

  1. Launch the app
    or
  2. Tap on the menu button

*Expected behavior
The border should not appear.

Screenshots
I attached a screenshot.

Additional context
It is probably not a bug and a result of my inexperience but this is the best approach I could come up with to ask for help.

name: Bug report(?) about: Red rectangular border (Strict Mode check?) **\*Device info (please complete the following information):** - Device: Samsung Galaxy Note 5 - OS: Andrid Nougat 7.0 - Arch: arm64 - Variant: monochrome - Version: 84.0.4147.89 **\*Is the bug related to extensions/on the extension-support version?** No **\*If not related to extensions/extension-support version, can the bug be reproduced with corresponding non-extension-support ungoogled-chromium-android version?** Yes **\*If not related to extensions/extension-support version, can the bug be reproduced with corresponding vanilla Chromium (the one directly from Google) version?** I don't know. **\*Describe the bug** Tapping on the menu button, launching the app and a few other things trigger it. A red border appears and flashes for less than a second. **\*To Reproduce** Steps to reproduce the behavior: 1. Launch the app or 1. Tap on the menu button **\*Expected behavior** The border should not appear. **Screenshots** I attached a screenshot. **Additional context** It is probably not a bug and a result of my inexperience but this is the best approach I could come up with to ask for help.
wchen342 commented 1 year ago
Poster
Owner

This happens with plain Chromium too, at least on my phones. Can you test the corresponding unmodified Chromium version?

This happens with plain Chromium too, at least on my phones. Can you test the corresponding unmodified Chromium version?
wchen342 commented 1 year ago
Poster
Owner

I looked it up and it seems to be the strict mode warning. It has no actual effect. If you are on an OEM system then go to developer options and check whether Strict mode enabled is toggled. On some system (LineageOS?) this seems to be always enabled though.

I looked it up and it seems to be the strict mode warning. It has no actual effect. If you are on an OEM system then go to developer options and check whether `Strict mode enabled` is toggled. On some system (LineageOS?) this seems to be always enabled though.
Poster

It is already disabled in developer settings and no build.prop modification had an effect. There is a thread where the issue is addressed, though I am not sure if it has anything to do with UC Android.

It is already disabled in developer settings and no build.prop modification had an effect. There is a [thread](https://github.com/kuoruan/Chromium-Android/issues/13) where the issue is addressed, though I am not sure if it has anything to do with UC Android.
wchen342 commented 1 year ago
Poster
Owner

There is no new information in that thread. The strict mode checks also exists in normal Chromium so this is not a UC problem.
Is there any specific reason you want to get rid of this?

There is no new information in that thread. The strict mode checks also exists in normal Chromium so this is not a UC problem. Is there any specific reason you want to get rid of this?
Poster

It seems like no one other than a few users have this issue, which the developers did not intend to cause. It is frustrating to use the browser when a bold and bright red border keeps flashing.
The border appears when;

  • The app is launched,
  • The menu button is selected,
  • The lock button before the URL is tapped on,
  • A text is selected,
  • You long press on a link,
  • Share and copy buttons -that appear when you tap on the address bar- are used,
  • A link that opens another app like Play Store is clicked on.

What's more, sometimes the border does not go away and stays there until one of the aforementioned actions take place to trigger the frame again. I once tried to restart my phone after the border was stuck on the screen, I could still see the border even when the Samsung logo -the one that shows up when the phone is shutting down- appeared. It disappeared when the phone was completely powered off.

It seems like no one other than a few users have this issue, which the developers did not intend to cause. It is frustrating to use the browser when a bold and bright red border keeps flashing. The border appears when; * The app is launched, * The menu button is selected, * The lock button before the URL is tapped on, * A text is selected, * You long press on a link, * Share and copy buttons -that appear when you tap on the address bar- are used, * A link that opens another app like Play Store is clicked on. What's more, sometimes the border does not go away and stays there until one of the aforementioned actions take place to trigger the frame again. I once tried to restart my phone after the border was stuck on the screen, I could still see the border even when the Samsung logo -the one that shows up when the phone is shutting down- appeared. It disappeared when the phone was completely powered off.
wchen342 commented 1 year ago
Poster
Owner

I could still see the border even when the Samsung logo -the one that shows up when the phone is shutting down- appeared

This sounds like system specific, as I have never seen this happening on my phones or in emulators. And the situations you mentioned seem to be a lot more than I have seen.

Also I noticed that the issues reported are all on Samsung Galaxy devices (another one is on Github). It is possible that Samsung did something different in their OS. Basically as I explained on Github, there are too many places (I did a rough search and there are ~250 files containing some kind of strict mode code) so it is not possible for me to remove all of them. The only way is to ask Chromium developers to disable this, or ask Samsung to investigate this issue (since it happens with unmodified Chromium too).

> I could still see the border even when the Samsung logo -the one that shows up when the phone is shutting down- appeared This sounds like system specific, as I have never seen this happening on my phones or in emulators. And the situations you mentioned seem to be a lot more than I have seen. Also I noticed that the issues reported are all on Samsung Galaxy devices (another one is on Github). It is possible that Samsung did something different in their OS. Basically as I explained on Github, there are too many places (I did a rough search and there are ~250 files containing some kind of strict mode code) so it is not possible for me to remove all of them. The only way is to ask Chromium developers to disable this, or ask Samsung to investigate this issue (since it happens with unmodified Chromium too).
Poster

I can reproduce this on a OnePlus 6T, so it is not a Samsung-only issue. The red border flash occurs, as @jidrivefya describes, when navigating within the app settings, opening the menu, etc. UC v84.0.4147.105 exhibits the bug, but Bromite and vanilla Chromium v84.0.4147.113 do not. (All were installed from F-Droid).

Strict mode is disabled in Developer Settings.

Both the phone OS (OxygenOS 10.3.5) and Ungoogled Chromium were recently updated, so I don't know if it began with the OS upgrade or the app upgrade, and I don't see old versions in the F-Droid repo for testing.

I can reproduce this on a OnePlus 6T, so it is not a Samsung-only issue. The red border flash occurs, as @jidrivefya describes, when navigating within the app settings, opening the menu, etc. UC v84.0.4147.105 exhibits the bug, but Bromite and vanilla Chromium v84.0.4147.113 do not. (All were installed from F-Droid). Strict mode is disabled in Developer Settings. Both the phone OS (OxygenOS 10.3.5) and Ungoogled Chromium were recently updated, so I don't know if it began with the OS upgrade or the app upgrade, and I don't see old versions in the F-Droid repo for testing.
Poster
Owner

Interesting. Can you post the adb log where StrictMode is mentioned? It should tell where strict mode is triggered.

Interesting. Can you post the adb log where StrictMode is mentioned? It should tell where strict mode is triggered.
Poster

Sure! Here is the StrictMode trace from logcat when I opened the "..." menu.

Sure! Here is the StrictMode trace from logcat when I opened the "..." menu.
Poster
There is no content yet.
20 KiB
Poster
Owner

The stack trace was obfuscated unfortunately. But I think I finally figured out what was going on since last version.

To put it simple: chromium now have multiple channels that has different package name suffixes. In pre v83, if android_channel="stable" the package name will remain what is configured (org.ungoogled.chromium), but since last version the package name will become org.ungoogled.chromium.stable which makes the installed package becomes a sperated app (so you will have two UCs in parallel, and data are not shared between them). That is why I changed android_channel to "default", which will allow the package name to stay the same.

Now this change has an unexpected side effect, that it will make java code decides that the "default" channel is a so called "Local Build", and so Strict Mode detection will be activated on such builds.

So either I somhow disable the strict mode detections completely, or I need to change the package name, which means you need to move your bookmarks/preferences (again). Also this will break bitwarden (https://github.com/wchen342/ungoogled-chromium-android/issues/38) again so they need to be notified.

The stack trace was obfuscated unfortunately. But I think I finally figured out what was going on since last version. To put it simple: chromium now have multiple channels that has different package name suffixes. In pre v83, if `android_channel="stable"` the package name will remain what is configured (`org.ungoogled.chromium`), but since last version the package name will become `org.ungoogled.chromium.stable` which makes the installed package becomes a sperated app (so you will have two UCs in parallel, and data are not shared between them). That is why I changed `android_channel` to `"default"`, which will allow the package name to stay the same. Now this change has an unexpected side effect, that it will make java code decides that the "default" channel is a so called "Local Build", and so Strict Mode detection will be activated on such builds. So either I somhow disable the strict mode detections completely, or I need to change the package name, which means you need to move your bookmarks/preferences (again). Also this will break bitwarden ([https://github.com/wchen342/ungoogled-chromium-android/issues/38](https://github.com/wchen342/ungoogled-chromium-android/issues/38)) again so they need to be notified.
Poster

Is there a way to modify the code that sets android_channel to default when there's no "stable" appended to the package name so that android_channel will be set "stable"?

Is there a way to modify the code that sets android_channel to default when there's no "stable" appended to the package name so that android_channel will be set "stable"?
Poster
Owner

I believe it's better avoid doing so as much as possible because such non-standard modification may cause other unexpected problems.

I believe it's better avoid doing so as much as possible because such non-standard modification may cause other unexpected problems.
Poster
Owner

Should be fixed in 1812d02.

Should be fixed in 1812d02.
wchen342 closed this issue 11 months ago
Sign in to join this conversation.
No Milestone
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.